Commit 71fbe886 authored Jul 10, 2020 by Lu Wei Committed by Andy Shevchenko Jul 14, 2020

platform/x86: intel-hid: Fix return value check in check_acpi_dev()



In the function check_acpi_dev(), if it fails to create
platform device, the return value is ERR_PTR() or NULL.
Thus it must use IS_ERR_OR_NULL() to check return value.

Fixes: ecc83e52 ("intel-hid: new hid event driver for hotkeys")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Lu Wei <luwei32@huawei.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

parent aff374df

drivers/platform/x86/intel-hid.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -571,7 +571,7 @@ check_acpi_dev(acpi_handle handle, u32 lvl, void context, void *rv)
		return AE_OK;

		if (acpi_match_device_ids(dev, ids) == 0)
		if (acpi_create_platform_device(dev, NULL))
		if (!IS_ERR_OR_NULL(acpi_create_platform_device(dev, NULL)))
		dev_info(&dev->dev,
		"intel-hid: created platform device\n");

Admin message