Commit 71e4eda8 authored Oct 06, 2007 by Benjamin Herrenschmidt Committed by Linus Torvalds Oct 06, 2007

Fix non-terminated PCI match table in PowerMac IDE



The PCI device table in the powermac IDE driver isn't properly
terminated.  Depending on how your kernel is linked and other random
factors, you can end up with this driver matched against any other PCI
device in your system, possibly crashing at boot.

Thanks to Heikki for tracking this down with me, the bug have been there
for some time, though it rarely hurts due to luck.  In this case, the
switch from .22 to .23-rc9 is causing it to show up due to differences
in the resulting layout of .data I suppose.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Paul Mackerras <pmac@au1.ibm.com>
Cc: Bartlomiej Zolnierkiewicz <B.Zolnierkiewicz@elka.pw.edu.pl>
Cc: Heikki Lindholm <holindho@cs.helsinki.fi>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 67dd5a25

drivers/ide/ppc/pmac.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -1546,6 +1546,7 @@ static struct pci_device_id pmac_ide_pci_match[] = {
		PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
		{ PCI_VENDOR_ID_APPLE, PCI_DEVICE_ID_APPLE_IPID2_ATA,
		PCI_ANY_ID, PCI_ANY_ID, 0, 0, 0},
		{},
		};

		static struct pci_driver pmac_ide_pci_driver = {

Admin message