Commit 71dc297c authored Aug 19, 2019 by Andy Shevchenko Committed by Wolfram Sang Aug 29, 2019

i2c: designware: assert reset when error happen at ->probe()

The commit c62ebb3d ("i2c: designware: Add support for an interface clock")
introduced an optional clock while missed correct error handling.
assert reset line back if error happen at ->probe().

Fixes: c62ebb3d ("i2c: designware: Add support for an interface clock")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>

parent f9bf7a89

drivers/i2c/busses/i2c-designware-platdrv.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -346,8 +346,10 @@ static int dw_i2c_plat_probe(struct platform_device *pdev)

		/* Optional interface clock */
		dev->pclk = devm_clk_get_optional(&pdev->dev, "pclk");
		if (IS_ERR(dev->pclk))
		return PTR_ERR(dev->pclk);
		if (IS_ERR(dev->pclk)) {
		ret = PTR_ERR(dev->pclk);
		goto exit_reset;
		}

		dev->clk = devm_clk_get(&pdev->dev, NULL);
		if (!i2c_dw_prepare_clk(dev, true)) {