Commit 71d4364a authored Jul 18, 2020 by Vladimir Oltean Committed by David S. Miller Jul 20, 2020

net: dsa: use the ETH_MIN_MTU and ETH_DATA_LEN default values



Now that DSA supports MTU configuration, undo the effects of commit
8b1efc0f ("net: remove MTU limits on a few ether_setup callers") and
let DSA interfaces use the default min_mtu and max_mtu specified by
ether_setup(). This is more important for min_mtu: since DSA is
Ethernet, the minimum MTU is the same as of any other Ethernet
interface, and definitely not zero. For the max_mtu, we have a callback
through which drivers can override that, if they want to.

Signed-off-by: Vladimir Oltean <olteanv@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f58d2598

net/dsa/slave.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -1754,11 +1754,8 @@ int dsa_slave_create(struct dsa_port *port)
		eth_hw_addr_inherit(slave_dev, master);
		slave_dev->priv_flags \|= IFF_NO_QUEUE;
		slave_dev->netdev_ops = &dsa_slave_netdev_ops;
		slave_dev->min_mtu = 0;
		if (ds->ops->port_max_mtu)
		slave_dev->max_mtu = ds->ops->port_max_mtu(ds, port->index);
		else
		slave_dev->max_mtu = ETH_MAX_MTU;
		SET_NETDEV_DEVTYPE(slave_dev, &dsa_type);

		netdev_for_each_tx_queue(slave_dev, dsa_slave_set_lockdep_class_one,

Admin message