debug: add the end-of-trace marker and the module list to (71c33911) · Commits · 戴 / test

Unlike oopses, WARN_ON() currently does't print the loaded modules list. This makes it harder to take action on certain bug reports. For example, recently there were a set of WARN_ON()s reported in the mac80211 stack, which were just signalling a driver bug. It takes then anther round trip to the bug reporter (if he responds at all) to find out which driver is at fault. Another issue is that, unlike oopses, WARN_ON() doesn't currently printk the helpful "cut here" line, nor the "end of trace" marker. Now that WARN_ON() is out of line, the size increase due to this is minimal and it's worth adding. Signed-off-by:

Arjan van de Ven <arjan@linux.intel.com> Signed-off-by:

Ingo Molnar <mingo@elte.hu> Signed-off-by:

Thomas Gleixner <tglx@linutronix.de>

kernel/panic.c

+12 −4

Original line number	Diff line number	Diff line
		@@ -281,6 +281,13 @@ static int init_oops_id(void)
		}
		late_initcall(init_oops_id);

		static void print_oops_end_marker(void)
		{
		init_oops_id();
		printk(KERN_WARNING "---[ end trace %016llx ]---\n",
		(unsigned long long)oops_id);
		}

		/*
		* Called when the architecture exits its oops handler, after printing
		* everything.
		@@ -288,9 +295,7 @@ late_initcall(init_oops_id);
		void oops_exit(void)
		{
		do_oops_enter_exit();
		init_oops_id();
		printk(KERN_WARNING "---[ end trace %016llx ]---\n",
		(unsigned long long)oops_id);
		print_oops_end_marker();
		}

		#ifdef WANT_WARN_ON_SLOWPATH
		@@ -298,11 +303,14 @@ void warn_on_slowpath(const char *file, int line)
		{
		char function[KSYM_SYMBOL_LEN];
		unsigned long caller = (unsigned long) __builtin_return_address(0);

		sprint_symbol(function, caller);

		printk(KERN_WARNING "------------[ cut here ]------------\n");
		printk(KERN_WARNING "WARNING: at %s:%d %s()\n", file,
		line, function);
		print_modules();
		dump_stack();
		print_oops_end_marker();
		}
		EXPORT_SYMBOL(warn_on_slowpath);
		#endif

Admin message