Commit 71bc0334 authored Mar 06, 2020 by Luca Coelho

iwlwifi: check allocated pointer when allocating conf_tlvs

We were erroneously checking the length of the tlv instead of checking
the pointer returned by kmemdup() when allocating dbg_conf_tlv[].
This was probably a typo. Fix it by checking the returned pointer
instead of the length.

Reported-by: Markus Elfring <Markus.Elfring@web.de>
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://lore.kernel.org/r/iwlwifi.20200306151128.06e00e6e980f.I9a890ce83493b79892a5f690d12016525317fa7e@changeid

parent cb377dfd

drivers/net/wireless/intel/iwlwifi/iwl-drv.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1467,7 +1467,7 @@ static void iwl_req_fw_callback(const struct firmware ucode_raw, void context)
		kmemdup(pieces->dbg_conf_tlv[i],
		pieces->dbg_conf_tlv_len[i],
		GFP_KERNEL);
		if (!pieces->dbg_conf_tlv_len[i])
		if (!pieces->dbg_conf_tlv[i])
		goto out_free_fw;
		}
		}