Commit 719b85c3 authored Oct 30, 2019 by Haiyang Zhang Committed by David S. Miller Oct 30, 2019

hv_netvsc: Fix error handling in netvsc_attach()



If rndis_filter_open() fails, we need to remove the rndis device created
in earlier steps, before returning an error code. Otherwise, the retry of
netvsc_attach() from its callers will fail and hang.

Fixes: 7b2ee50c ("hv_netvsc: common detach logic")
Signed-off-by: Haiyang Zhang <haiyangz@microsoft.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent c4509a5a

drivers/net/hyperv/netvsc_drv.c

+8 −1

Original line number	Diff line number	Diff line
		@@ -982,7 +982,7 @@ static int netvsc_attach(struct net_device *ndev,
		if (netif_running(ndev)) {
		ret = rndis_filter_open(nvdev);
		if (ret)
		return ret;
		goto err;

		rdev = nvdev->extension;
		if (!rdev->link_state)
		@@ -990,6 +990,13 @@ static int netvsc_attach(struct net_device *ndev,
		}

		return 0;

		err:
		netif_device_detach(ndev);

		rndis_filter_device_remove(hdev, nvdev);

		return ret;
		}

		static int netvsc_set_channels(struct net_device *net,

Admin message