Commit 718360c5 authored Jan 30, 2014 by Noah Massey Committed by Trond Myklebust Jan 31, 2014

nfs: fix setting of ACLs on file creation.



nfs3_get_acl() tries to skip posix equivalent ACLs, but misinterprets
the return value of posix_acl_equiv_mode(). Fix it.

This is a regression introduced by
"nfs: use generic posix ACL infrastructure for v3 Posix ACLs"

CC: Christoph Hellwig <hch@infradead.org>
CC: linux-nfs@vger.kernel.org
CC: linux-fsdevel@vger.kernel.org

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 8a1f006a

fs/nfs/nfs3acl.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -80,7 +80,7 @@ struct posix_acl nfs3_get_acl(struct inode inode, int type)
		}

		if (res.acl_access != NULL) {
		if (posix_acl_equiv_mode(res.acl_access, NULL) \|\|
		if ((posix_acl_equiv_mode(res.acl_access, NULL) == 0) \|\|
		res.acl_access->a_count == 0) {
		posix_acl_release(res.acl_access);
		res.acl_access = NULL;

Admin message