ASoC: SOF: Intel: hda: remove misleading error trace from IRQ thread (717dedb1) · Commits · 戴 / test

Downgrade "nothing to do in IRQ thread" message from error to a debug message in the IPC interrupt handler thread. The spurious wake-up can happen if a HDA stream interrupt is raised while the IPC interrupt thread is running. IPC functionality is not impacted by this condition, so debug is a more appropriate trace level. Signed-off-by:

Kai Vehmanen <kai.vehmanen@linux.intel.com> Signed-off-by:

Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20190722141402.7194-21-pierre-louis.bossart@linux.intel.com Signed-off-by:

Mark Brown <broonie@kernel.org>

sound/soc/sof/intel/cnl.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -101,8 +101,8 @@ static irqreturn_t cnl_ipc_irq_thread(int irq, void *context)
		/*
		* This interrupt is not shared so no need to return IRQ_NONE.
		*/
		dev_err_ratelimited(sdev->dev,
		"error: nothing to do in IRQ thread\n");
		dev_dbg_ratelimited(sdev->dev,
		"nothing to do in IPC IRQ thread\n");
		}

		/* re-enable IPC interrupt */

sound/soc/sof/intel/hda-ipc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -224,8 +224,8 @@ irqreturn_t hda_dsp_ipc_irq_thread(int irq, void *context)
		/*
		* This interrupt is not shared so no need to return IRQ_NONE.
		*/
		dev_err_ratelimited(sdev->dev,
		"error: nothing to do in IRQ thread\n");
		dev_dbg_ratelimited(sdev->dev,
		"nothing to do in IPC IRQ thread\n");
		}

		/* re-enable IPC interrupt */

Admin message