Commit 7170cf47 authored Mar 27, 2020 by Julien Thierry Committed by Ingo Molnar Apr 22, 2020

objtool: Ignore empty alternatives



The .alternatives section can contain entries with no original
instructions. Objtool will currently crash when handling such an entry.

Just skip that entry, but still give a warning to discourage useless
entries.

Signed-off-by: Julien Thierry <jthierry@redhat.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Reviewed-by: Miroslav Benes <mbenes@suse.cz>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>

parent 0699e551

tools/objtool/check.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -905,6 +905,12 @@ static int add_special_section_alts(struct objtool_file *file)
		}

		if (special_alt->group) {
		if (!special_alt->orig_len) {
		WARN_FUNC("empty alternative entry",
		orig_insn->sec, orig_insn->offset);
		continue;
		}

		ret = handle_group_alt(file, special_alt, orig_insn,
		&new_insn);
		if (ret)

Admin message