Commit 716ad875 authored May 16, 2008 by Greg Kroah-Hartman

ide: fix race in device_create



There is a race from when a device is created with device_create() and
then the drvdata is set with a call to dev_set_drvdata() in which a
sysfs file could be open, yet the drvdata will be NULL, causing all
sorts of bad things to happen.

This patch fixes the problem by using the new function,
device_create_drvdata().

Cc: Kay Sievers <kay.sievers@vrfy.org>
Acked-by: Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 8b485877

drivers/ide/ide-probe.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -648,13 +648,12 @@ static int ide_register_port(ide_hwif_t *hwif)

		get_device(&hwif->gendev);

		hwif->portdev = device_create(ide_port_class, &hwif->gendev,
		MKDEV(0, 0), hwif->name);
		hwif->portdev = device_create_drvdata(ide_port_class, &hwif->gendev,
		MKDEV(0, 0), hwif, hwif->name);
		if (IS_ERR(hwif->portdev)) {
		ret = PTR_ERR(hwif->portdev);
		device_unregister(&hwif->gendev);
		}
		dev_set_drvdata(hwif->portdev, hwif);
		out:
		return ret;
		}

Admin message