Commit 71614e1c authored Jul 11, 2020 by Andy Shevchenko Committed by Greg Kroah-Hartman Jul 21, 2020

Revert "serial: sh-sci: Initialize spinlock for uart console"

This reverts commit f38278e9.

There has been a quick fix against uninitialised lock revealed by
the commit f743061a ("serial: core: Initialise spin lock before use
in uart_configure_port()"). Since we have now better fix in serial core,
this may be safely reverted.

Fixes: f38278e9 ("serial: sh-sci: Initialize spinlock for uart console")
Depends-on: f743061a ("serial: core: Initialise spin lock before use in uart_configure_port()")
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20200711135346.71171-5-andriy.shevchenko@linux.intel.com

Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent dfe51d97

drivers/tty/serial/sh-sci.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -3301,9 +3301,6 @@ static int sci_probe_single(struct platform_device *dev,
		sciport->port.flags \|= UPF_HARD_FLOW;
		}

		if (sci_uart_driver.cons->index == sciport->port.line)
		spin_lock_init(&sciport->port.lock);

		ret = uart_add_one_port(&sci_uart_driver, &sciport->port);
		if (ret) {
		sci_cleanup_single(sciport);