Commit 7159dbda authored by Heiner Kallweit's avatar Heiner Kallweit Committed by Wolfram Sang
Browse files

i2c: core: improve return value handling of i2c_new_device and i2c_new_dummy 



Currently i2c_new_device and i2c_new_dummy return just NULL in error
case although they have more error details internally. Therefore move
the functionality into new functions returning detailed errors and
add wrappers for compatibility with the current API.

This allows to use these functions with detailed error codes within
the i2c core or for API extensions.

Signed-off-by: default avatarHeiner Kallweit <hkallweit1@gmail.com>
[wsa: rename new functions and fix minor kdoc issues]
Signed-off-by: default avatarWolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: default avatarPeter Rosin <peda@axentia.se>
Reviewed-by: default avatarKieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Signed-off-by: default avatarWolfram Sang <wsa@the-dreams.de>
parent a6a4b66b

drivers/i2c/i2c-core-base.c

+61 −13
Original line number Diff line number Diff line
@@ -714,7 +714,7 @@ static int i2c_dev_irq_from_resources(const struct resource *resources, 
}



/**

 * i2c_new_device - instantiate an i2c device

 * i2c_new_client_device - instantiate an i2c device

 * @adap: the adapter managing the device

 * @info: describes one I2C device; bus_num is ignored

 * Context: can sleep
@@ -727,17 +727,17 @@ static int i2c_dev_irq_from_resources(const struct resource *resources, 
 * before any i2c_adapter could exist.

 *

 * This returns the new i2c client, which may be saved for later use with

 * i2c_unregister_device(); or NULL to indicate an error.

 * i2c_unregister_device(); or an ERR_PTR to describe the error.

 */

struct i2c_client *

i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)

static struct i2c_client *

i2c_new_client_device(struct i2c_adapter *adap, struct i2c_board_info const *info)

{

	struct i2c_client	*client;

	int			status;



	client = kzalloc(sizeof *client, GFP_KERNEL);

	if (!client)

		return NULL;

		return ERR_PTR(-ENOMEM);



	client->adapter = adap;
@@ -803,7 +803,31 @@ out_err: 
		client->name, client->addr, status);

out_err_silent:

	kfree(client);

	return NULL;

	return ERR_PTR(status);

}

EXPORT_SYMBOL_GPL(i2c_new_client_device);



/**

 * i2c_new_device - instantiate an i2c device

 * @adap: the adapter managing the device

 * @info: describes one I2C device; bus_num is ignored

 * Context: can sleep

 *

 * This deprecated function has the same functionality as

 * @i2c_new_client_device, it just returns NULL instead of an ERR_PTR in case of

 * an error for compatibility with current I2C API. It will be removed once all

 * users are converted.

 *

 * This returns the new i2c client, which may be saved for later use with

 * i2c_unregister_device(); or NULL to indicate an error.

 */

struct i2c_client *

i2c_new_device(struct i2c_adapter *adap, struct i2c_board_info const *info)

{

	struct i2c_client *ret;



	ret = i2c_new_client_device(adap, info);

	return IS_ERR(ret) ? NULL : ret;

}

EXPORT_SYMBOL_GPL(i2c_new_device);
@@ -854,7 +878,7 @@ static struct i2c_driver dummy_driver = { 
};



/**

 * i2c_new_dummy - return a new i2c device bound to a dummy driver

 * i2c_new_dummy_device - return a new i2c device bound to a dummy driver

 * @adapter: the adapter managing the device

 * @address: seven bit address to be used

 * Context: can sleep
@@ -869,15 +893,39 @@ static struct i2c_driver dummy_driver = { 
 * different driver.

 *

 * This returns the new i2c client, which should be saved for later use with

 * i2c_unregister_device(); or NULL to indicate an error.

 * i2c_unregister_device(); or an ERR_PTR to describe the error.

 */

struct i2c_client *i2c_new_dummy(struct i2c_adapter *adapter, u16 address)

static struct i2c_client *

i2c_new_dummy_device(struct i2c_adapter *adapter, u16 address)

{

	struct i2c_board_info info = {

		I2C_BOARD_INFO("dummy", address),

	};



	return i2c_new_device(adapter, &info);

	return i2c_new_client_device(adapter, &info);

}

EXPORT_SYMBOL_GPL(i2c_new_dummy_device);



/**

 * i2c_new_dummy - return a new i2c device bound to a dummy driver

 * @adapter: the adapter managing the device

 * @address: seven bit address to be used

 * Context: can sleep

 *

 * This deprecated function has the same functionality as @i2c_new_dummy_device,

 * it just returns NULL instead of an ERR_PTR in case of an error for

 * compatibility with current I2C API. It will be removed once all users are

 * converted.

 *

 * This returns the new i2c client, which should be saved for later use with

 * i2c_unregister_device(); or NULL to indicate an error.

 */

struct i2c_client *i2c_new_dummy(struct i2c_adapter *adapter, u16 address)

{

	struct i2c_client *ret;



	ret = i2c_new_dummy_device(adapter, address);

	return IS_ERR(ret) ? NULL : ret;

}

EXPORT_SYMBOL_GPL(i2c_new_dummy);
@@ -1000,9 +1048,9 @@ i2c_sysfs_new_device(struct device *dev, struct device_attribute *attr, 
		info.flags |= I2C_CLIENT_SLAVE;

	}



	client = i2c_new_device(adap, &info);

	if (!client)

		return -EINVAL;

	client = i2c_new_client_device(adap, &info);

	if (IS_ERR(client))

		return PTR_ERR(client);



	/* Keep track of the added device */

	mutex_lock(&adap->userspace_clients_lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE