gpio: rcar: Cache gpiochip_get_data() return value (714d3a29) · Commits · 戴 / test

Since commit ("gpio: move the subdriver data pointer into gpio_device") changed gpiochip_get_data() to an out-of-line function, it is now worthwhile to avoid multiple calls in a row by caching its return value in a local variable. Signed-off-by:

Geert Uytterhoeven <geert+renesas@glider.be> Signed-off-by:

Bartosz Golaszewski <bgolaszewski@baylibre.com>

drivers/gpio/gpio-rcar.c

+4 −3

Original line number	Diff line number	Diff line
		@@ -295,14 +295,15 @@ static int gpio_rcar_direction_input(struct gpio_chip *chip, unsigned offset)

		static int gpio_rcar_get(struct gpio_chip *chip, unsigned offset)
		{
		struct gpio_rcar_priv *p = gpiochip_get_data(chip);
		u32 bit = BIT(offset);

		/* testing on r8a7790 shows that INDT does not show correct pin state
		* when configured as output, so use OUTDT in case of output pins */
		if (gpio_rcar_read(gpiochip_get_data(chip), INOUTSEL) & bit)
		return !!(gpio_rcar_read(gpiochip_get_data(chip), OUTDT) & bit);
		if (gpio_rcar_read(p, INOUTSEL) & bit)
		return !!(gpio_rcar_read(p, OUTDT) & bit);
		else
		return !!(gpio_rcar_read(gpiochip_get_data(chip), INDT) & bit);
		return !!(gpio_rcar_read(p, INDT) & bit);
		}

		static void gpio_rcar_set(struct gpio_chip *chip, unsigned offset, int value)

Admin message