Commit 714b33d1 authored Sep 17, 2013 by Neil Horman Committed by Herbert Xu Sep 24, 2013

crypto: ansi_cprng - Fix off by one error in non-block size request



Stephan Mueller reported to me recently a error in random number generation in
the ansi cprng. If several small requests are made that are less than the
instances block size, the remainder for loop code doesn't increment
rand_data_valid in the last iteration, meaning that the last bytes in the
rand_data buffer gets reused on the subsequent smaller-than-a-block request for
random data.

The fix is pretty easy, just re-code the for loop to make sure that
rand_data_valid gets incremented appropriately

Signed-off-by: Neil Horman <nhorman@tuxdriver.com>
Reported-by: Stephan Mueller <stephan.mueller@atsec.com>
CC: Stephan Mueller <stephan.mueller@atsec.com>
CC: Petr Matousek <pmatouse@redhat.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>
CC: "David S. Miller" <davem@davemloft.net>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ec795ad8

crypto/ansi_cprng.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -230,11 +230,11 @@ remainder:
		*/
		if (byte_count < DEFAULT_BLK_SZ) {
		empty_rbuf:
		for (; ctx->rand_data_valid < DEFAULT_BLK_SZ;
		ctx->rand_data_valid++) {
		while (ctx->rand_data_valid < DEFAULT_BLK_SZ) {
		*ptr = ctx->rand_data[ctx->rand_data_valid];
		ptr++;
		byte_count--;
		ctx->rand_data_valid++;
		if (byte_count == 0)
		goto done;
		}

Admin message