Commit 71425189 authored Dec 04, 2020 by Sebastian Andrzej Siewior Committed by Jens Axboe Dec 17, 2020

blk-mq: Don't complete on a remote CPU in force threaded mode



With force threaded interrupts enabled, raising softirq from an SMP
function call will always result in waking the ksoftirqd thread. This is
not optimal given that the thread runs at SCHED_OTHER priority.

Completing the request in hard IRQ-context on PREEMPT_RT (which enforces
the force threaded mode) is bad because the completion handler may
acquire sleeping locks which violate the locking context.

Disable request completing on a remote CPU in force threaded mode.

Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Daniel Wagner <dwagner@suse.de>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

parent 53a7f655

block/blk-mq.c

+8 −0

Original line number	Diff line number	Diff line
		@@ -650,6 +650,14 @@ static inline bool blk_mq_complete_need_ipi(struct request *rq)
		if (!IS_ENABLED(CONFIG_SMP) \|\|
		!test_bit(QUEUE_FLAG_SAME_COMP, &rq->q->queue_flags))
		return false;
		/*
		* With force threaded interrupts enabled, raising softirq from an SMP
		* function call will always result in waking the ksoftirqd thread.
		* This is probably worse than completing the request on a different
		* cache domain.
		*/
		if (force_irqthreads)
		return false;

		/* same CPU or cache domain? Complete locally */
		if (cpu == rq->mq_ctx->cpu \|\|

Admin message