Commit 713bf88b authored Mar 08, 2010 by Dave Chinner Committed by Alex Elder May 19, 2010

xfs: fix reservation release commit flag in xfs_bmap_add_attrfork()



xfs_bmap_add_attrfork() passes XFS_TRANS_PERM_LOG_RES to xfs_trans_commit()
to indicate that the commit should release the permanent log reservation
as part of the commit. This is wrong - the correct flag is
XFS_TRANS_RELEASE_LOG_RES - and it is only by the chance that both these
flags have the value of 0x4 that the code is doing the right thing.

Fix it by changing to use the correct flag.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>

parent 8e123850

fs/xfs/xfs_bmap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -3829,7 +3829,7 @@ xfs_bmap_add_attrfork(
		}
		if ((error = xfs_bmap_finish(&tp, &flist, &committed)))
		goto error2;
		error = xfs_trans_commit(tp, XFS_TRANS_PERM_LOG_RES);
		error = xfs_trans_commit(tp, XFS_TRANS_RELEASE_LOG_RES);
		ASSERT(ip->i_df.if_ext_max ==
		XFS_IFORK_DSIZE(ip) / (uint)sizeof(xfs_bmbt_rec_t));
		return error;

Admin message