Commit 71352b8c authored Nov 28, 2019 by Rasmus Villemoes Committed by Li Yang Dec 09, 2019

soc: fsl: qe: drop pointless check in qe_sdma_init()



The sdma member of struct qe_immap is not at offset zero, so even if
qe_immr wasn't initialized yet (i.e. NULL), &qe_immr->sdma would not
be NULL.

Reviewed-by: Timur Tabi <timur@kernel.org>
Signed-off-by: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Signed-off-by: Li Yang <leoyang.li@nxp.com>

parent 4c3e565c

drivers/soc/fsl/qe/qe.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -367,9 +367,6 @@ static int qe_sdma_init(void)
		struct sdma __iomem *sdma = &qe_immr->sdma;
		static s32 sdma_buf_offset = -ENOMEM;

		if (!sdma)
		return -ENODEV;

		/* allocate 2 internal temporary buffers (512 bytes size each) for
		* the SDMA */
		if (sdma_buf_offset < 0) {

Admin message