Commit 71271269 authored by Ricardo Neri's avatar Ricardo Neri Committed by Ingo Molnar
Browse files

x86/insn-eval: Extend get_seg_base_addr() to also obtain segment limit 



In protected mode, it is common to want to obtain the limit of a segment
along with its base address. This is useful, for instance, to verify that
an effective address lies within a segment before computing a linear
address.

Up to this point, this library only computes linear addresses in long
mode. Subsequent patches will include support for protected mode. Support
to verify the segment limit will be needed.

Signed-off-by: default avatarRicardo Neri <ricardo.neri-calderon@linux.intel.com>
Cc: Adam Buchbinder <adam.buchbinder@gmail.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: Brian Gerst <brgerst@gmail.com>
Cc: Chen Yucong <slaoub@gmail.com>
Cc: Chris Metcalf <cmetcalf@mellanox.com>
Cc: Colin Ian King <colin.king@canonical.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Dmitry Vyukov <dvyukov@google.com>
Cc: Huang Rui <ray.huang@amd.com>
Cc: Jiri Slaby <jslaby@suse.cz>
Cc: Jonathan Corbet <corbet@lwn.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Lorenzo Stoakes <lstoakes@gmail.com>
Cc: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Qiaowei Ren <qiaowei.ren@intel.com>
Cc: Ravi V. Shankar <ravi.v.shankar@intel.com>
Cc: Shuah Khan <shuah@kernel.org>
Cc: Thomas Garnier <thgarnie@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Vlastimil Babka <vbabka@suse.cz>
Cc: ricardo.neri@intel.com
Link: http://lkml.kernel.org/r/1509148310-30862-2-git-send-email-ricardo.neri-calderon@linux.intel.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 10890444

arch/x86/lib/insn-eval.c

+19 −8
Original line number Diff line number Diff line
@@ -729,25 +729,29 @@ int insn_get_modrm_rm_off(struct insn *insn, struct pt_regs *regs) 
}



/**

 * get_seg_base_addr() - obtain base address of a segment

 * get_seg_base_limit() - obtain base address and limit of a segment

 * @insn:	Instruction. Must be valid.

 * @regs:	Register values as seen when entering kernel mode

 * @regoff:	Operand offset, in pt_regs, used to resolve segment descriptor

 * @base:	Obtained segment base

 * @limit:	Obtained segment limit

 *

 * Obtain the base address of the segment associated with the operand @regoff

 * and, if any or allowed, override prefixes in @insn. This function is

 * Obtain the base address and limit of the segment associated with the operand

 * @regoff and, if any or allowed, override prefixes in @insn. This function is

 * different from insn_get_seg_base() as the latter does not resolve the segment

 * associated with the instruction operand.

 * associated with the instruction operand. If a limit is not needed (e.g.,

 * when running in long mode), @limit can be NULL.

 *

 * Returns:

 *

 * 0 on success. @base will contain the base address of the resolved segment.

 * 0 on success. @base and @limit will contain the base address and of the

 * resolved segment, respectively.

 *

 * -EINVAL on error.

 */

static int get_seg_base_addr(struct insn *insn, struct pt_regs *regs,

			     int regoff, unsigned long *base)

static int get_seg_base_limit(struct insn *insn, struct pt_regs *regs,

			      int regoff, unsigned long *base,

			      unsigned long *limit)

{

	int seg_reg_idx;
@@ -762,6 +766,13 @@ static int get_seg_base_addr(struct insn *insn, struct pt_regs *regs, 
	if (*base == -1L)

		return -EINVAL;



	if (!limit)

		return 0;



	*limit = get_seg_limit(regs, seg_reg_idx);

	if (!(*limit))

		return -EINVAL;



	return 0;

}
@@ -843,7 +854,7 @@ void __user *insn_get_addr_ref(struct insn *insn, struct pt_regs *regs) 
		eff_addr += insn->displacement.value;

	}



	ret = get_seg_base_addr(insn, regs, addr_offset, &seg_base);

	ret = get_seg_base_limit(insn, regs, addr_offset, &seg_base, NULL);

	if (ret)

		goto out;

CRA Git | Maintained and supported by SUSTech CRA and CCSE