Commit 7126bd5c authored Aug 01, 2020 by Florian Westphal Committed by David S. Miller Aug 01, 2020

mptcp: fix syncookie build error on UP



kernel test robot says:
net/mptcp/syncookies.c: In function 'mptcp_join_cookie_init':
include/linux/kernel.h:47:38: warning: division by zero [-Wdiv-by-zero]
 #define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]) + __must_be_array(arr))

I forgot that spinock_t size is 0 on UP, so ARRAY_SIZE cannot be used.

Fixes: 9466a1cc ("mptcp: enable JOIN requests even if cookies are in use")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8b66a6fd

net/mptcp/syncookies.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -125,8 +125,6 @@ void __init mptcp_join_cookie_init(void)
		{
		int i;

		for (i = 0; i < ARRAY_SIZE(join_entry_locks); i++)
		for (i = 0; i < COOKIE_JOIN_SLOTS; i++)
		spin_lock_init(&join_entry_locks[i]);

		BUILD_BUG_ON(ARRAY_SIZE(join_entry_locks) != ARRAY_SIZE(join_entries));
		}

Admin message