Commit 711eff3a authored Feb 07, 2019 by Krish Sadhukhan Committed by Paolo Bonzini Mar 28, 2019

kvm: nVMX: Add a vmentry check for HOST_SYSENTER_ESP and HOST_SYSENTER_EIP fields



According to section "Checks on VMX Controls" in Intel SDM vol 3C, the
following check is performed on vmentry of L2 guests:

    On processors that support Intel 64 architecture, the IA32_SYSENTER_ESP
    field and the IA32_SYSENTER_EIP field must each contain a canonical
    address.

Signed-off-by: Krish Sadhukhan <krish.sadhukhan@oracle.com>
Reviewed-by: Mihai Carabas <mihai.carabas@oracle.com>
Reviewed-by: Jim Mattson <jmattson@google.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>

parent 05d5a486

arch/x86/kvm/vmx/nested.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -2585,6 +2585,11 @@ static int nested_check_host_control_regs(struct kvm_vcpu *vcpu,
		!nested_host_cr4_valid(vcpu, vmcs12->host_cr4) \|\|
		!nested_cr3_valid(vcpu, vmcs12->host_cr3))
		return -EINVAL;

		if (is_noncanonical_address(vmcs12->host_ia32_sysenter_esp, vcpu) \|\|
		is_noncanonical_address(vmcs12->host_ia32_sysenter_eip, vcpu))
		return -EINVAL;

		/*
		* If the load IA32_EFER VM-exit control is 1, bits reserved in the
		* IA32_EFER MSR must be 0 in the field for that register. In addition,

Admin message