Commit 710ae728 authored Jan 18, 2019 by Ido Schimmel Committed by David S. Miller Jan 18, 2019

net: bridge: Mark FDB entries that were added by user as such



Externally learned entries can be added by a user or by a switch driver
that is notifying the bridge driver about entries that were learned in
hardware.

In the first case, the entries are not marked with the 'added_by_user'
flag, which causes switch drivers to ignore them and not offload them.

The 'added_by_user' flag can be set on externally learned FDB entries
based on the 'swdev_notify' parameter in br_fdb_external_learn_add(),
which effectively means if the created / updated FDB entry was added by
a user or not.

Fixes: 816a3bed ("switchdev: Add fdb.added_by_user to switchdev notifications")
Signed-off-by: Ido Schimmel <idosch@mellanox.com>
Reported-by: Alexander Petrovskiy <alexpe@mellanox.com>
Reviewed-by: Petr Machata <petrm@mellanox.com>
Cc: Roopa Prabhu <roopa@cumulusnetworks.com>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: bridge@lists.linux-foundation.org
Signed-off-by: David S. Miller <davem@davemloft.net>

parent a11dcd64

net/bridge/br_fdb.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1128,6 +1128,8 @@ int br_fdb_external_learn_add(struct net_bridge br, struct net_bridge_port p,
		err = -ENOMEM;
		goto err_unlock;
		}
		if (swdev_notify)
		fdb->added_by_user = 1;
		fdb->added_by_external_learn = 1;
		fdb_notify(br, fdb, RTM_NEWNEIGH, swdev_notify);
		} else {
		@@ -1147,6 +1149,9 @@ int br_fdb_external_learn_add(struct net_bridge br, struct net_bridge_port p,
		modified = true;
		}

		if (swdev_notify)
		fdb->added_by_user = 1;

		if (modified)
		fdb_notify(br, fdb, RTM_NEWNEIGH, swdev_notify);
		}

Admin message