Commit 70ea1636 authored by Dan Carpenter's avatar Dan Carpenter Committed by Jarkko Sakkinen
Browse files

tpm: silence an array overflow warning 



We should check that we're within bounds first before checking that
"chip->active_banks[i] != TPM2_ALG_ERROR" so I've re-ordered the two
checks.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Signed-off-by: default avatarJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
parent a118cf2a

drivers/char/tpm/tpm-interface.c

+2 −2
Original line number Diff line number Diff line
@@ -800,8 +800,8 @@ int tpm_pcr_extend(u32 chip_num, int pcr_idx, const u8 *hash) 
	if (chip->flags & TPM_CHIP_FLAG_TPM2) {

		memset(digest_list, 0, sizeof(digest_list));



		for (i = 0; chip->active_banks[i] != TPM2_ALG_ERROR &&

		     i < ARRAY_SIZE(chip->active_banks); i++) {

		for (i = 0; i < ARRAY_SIZE(chip->active_banks) &&

			    chip->active_banks[i] != TPM2_ALG_ERROR; i++) {

			digest_list[i].alg_id = chip->active_banks[i];

			memcpy(digest_list[i].digest, hash, TPM_DIGEST_SIZE);

			count++;

CRA Git | Maintained and supported by SUSTech CRA and CCSE