staging: comedi: mpc624: tidy up subdevice init (70e80335) · Commits · 戴 / test

For aesthetics, add some whitespace to the subdevice init. Remove the unnecessary switch() code used to set the maxdata and range_table. Signed-off-by:

H Hartley Sweeten <hsweeten@visionengravers.com> Reviewed-by:

Ian Abbott <abbotti@mev.co.uk> Signed-off-by:

Greg Kroah-Hartman <gregkh@linuxfoundation.org>

drivers/staging/comedi/drivers/mpc624.c

+8 −17

Original line number	Diff line number	Diff line
		@@ -299,23 +299,14 @@ static int mpc624_attach(struct comedi_device dev, struct comedi_devconfig it)
		if (ret)
		return ret;

		/* Analog Input subdevice */
		s = &dev->subdevices[0];
		s->type = COMEDI_SUBD_AI;
		s->subdev_flags = SDF_READABLE \| SDF_DIFF;
		s->n_chan = 8;
		switch (it->options[1]) {
		default:
		s->maxdata = 0x3FFFFFFF;
		}

		switch (it->options[1]) {
		case 0:
		s->range_table = &range_mpc624_bipolar1;
		break;
		default:
		s->range_table = &range_mpc624_bipolar10;
		}
		s->len_chanlist = 1;
		s->maxdata = 0x3fffffff;
		s->range_table = (it->options[1] == 0) ? &range_mpc624_bipolar1
		: &range_mpc624_bipolar10;
		s->insn_read = mpc624_ai_rinsn;

		return 0;

Admin message