Commit 70e37988 authored Aug 21, 2020 by Christophe JAILLET Committed by Sagi Grimberg Aug 28, 2020

nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'



The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent
in this function.

Use 'spin_lock_irqsave()' also here, as there is no guarantee that
interruptions are disabled at that point, according to surrounding code.

Fixes: a97ec51b ("nvmet_fc: Rework target side abort handling")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>

parent 7cd49f75

drivers/nvme/target/fc.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -2342,9 +2342,9 @@ nvmet_fc_fod_op_done(struct nvmet_fc_fcp_iod *fod)
		return;
		if (fcpreq->fcp_error \|\|
		fcpreq->transferred_length != fcpreq->transfer_length) {
		spin_lock(&fod->flock);
		spin_lock_irqsave(&fod->flock, flags);
		fod->abort = true;
		spin_unlock(&fod->flock);
		spin_unlock_irqrestore(&fod->flock, flags);

		nvmet_req_complete(&fod->req, NVME_SC_INTERNAL);
		return;

Admin message