Commit 70dabaed authored Jan 08, 2014 by Nicolin Chen Committed by Vinod Koul Jan 13, 2014

dma: imx-sdma: Assign a default script number for ROM firmware cases

i.MX series have inner firmware in its ROM code: when SDMA isn't provided
any firmware from Kernel or rootfs, the default inner ROM firmware will be
activated. However the current driver doesn't assign any script number to
this situation, and those platform running in this case would be broken.

Thus this patch adds a default script number when no external firmware being
loaded so that people would continue to be able to use basic scripts to run
their platform without any firmware.

Reported-by: Fabio Estevam <fabio.estevam@freescale.com>
Signed-off-by: Nicolin Chen <Guangyu.Chen@freescale.com>
Tested-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>

parent e5b28861

drivers/dma/imx-sdma.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1252,6 +1252,10 @@ static void sdma_add_scripts(struct sdma_engine *sdma,
		s32 saddr_arr = (u32 )sdma->script_addrs;
		int i;

		/* use the default firmware in ROM if missing external firmware */
		if (!sdma->script_number)
		sdma->script_number = SDMA_SCRIPT_ADDRS_ARRAY_SIZE_V1;

		for (i = 0; i < sdma->script_number; i++)
		if (addr_arr[i] > 0)
		saddr_arr[i] = addr_arr[i];

Admin message