Commit 70c86ace authored by Liang Zhen's avatar Liang Zhen Committed by Greg Kroah-Hartman
Browse files

staging/lustre/lnet: portal spreading rotor should be unsigned 



Portal spreading rotor should be unsigned, otherwise lnet may get
negative CPT number and access invalid addresses.

Signed-off-by: default avatarLiang Zhen <liang.zhen@intel.com>
Reviewed-on: http://review.whamcloud.com/11936
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-5639


Reviewed-by: default avatarAmir Shehata <amir.shehata@intel.com>
Reviewed-by: default avatarIsaac Huang <he.huang@intel.com>
Reviewed-by: default avatarDoug Oucharek <doug.s.oucharek@intel.com>
Signed-off-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent dbab2d85

drivers/staging/lustre/include/linux/lnet/lib-types.h

+1 −1
Original line number Diff line number Diff line
@@ -622,7 +622,7 @@ typedef struct lnet_portal { 
	/* Match table for each CPT */

	struct lnet_match_table	**ptl_mtables;

	/* spread rotor of incoming "PUT" */

	int			ptl_rotor;

	unsigned int		ptl_rotor;

	/* # active entries for this portal */

	int		     ptl_mt_nmaps;

	/* array of active entries' cpu-partition-id */

drivers/staging/lustre/lnet/lnet/lib-ptl.c

+4 −4
Original line number Diff line number Diff line
@@ -262,10 +262,10 @@ lnet_mt_of_match(struct lnet_match_info *info, struct lnet_msg *msg) 
{

	struct lnet_match_table	*mtable;

	struct lnet_portal	*ptl;

	int			nmaps;

	int			rotor;

	int			routed;

	int			cpt;

	unsigned int		nmaps;

	unsigned int		rotor;

	unsigned int		cpt;

	bool			routed;



	/* NB: called w/o lock */

	LASSERT(info->mi_portal < the_lnet.ln_nportals);

CRA Git | Maintained and supported by SUSTech CRA and CCSE