Commit 70b4de0b authored Jul 23, 2020 by Lee Jones Committed by Martin K. Petersen Jul 24, 2020

scsi: bfa: Remove set but unused variable 'rp'

This change subsequently makes 'rp_fcs' unused also.  Remove that too.

Fixes the following W=1 kernel build warning(s):

 drivers/scsi/bfa/bfa_fcpim.c: In function ‘bfa_fcpim_lunmask_delete’:
 drivers/scsi/bfa/bfa_fcpim.c:2338:22: warning: variable ‘rp’ set but not used [-Wunused-but-set-variable]
 2338 | struct bfa_rport_s *rp = NULL;
 | ^~

Link: https://lore.kernel.org/r/20200723122446.1329773-10-lee.jones@linaro.org


Cc: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
Cc: Sudarsana Kalluru <sudarsana.kalluru@qlogic.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 2ad6e0c3

drivers/scsi/bfa/bfa_fcpim.c

+1 −7

Original line number	Diff line number	Diff line
		@@ -2335,9 +2335,7 @@ bfa_fcpim_lunmask_delete(struct bfa_s bfa, u16 vf_id, wwn_t pwwn,
		wwn_t rpwwn, struct scsi_lun lun)
		{
		struct bfa_lun_mask_s *lunm_list;
		struct bfa_rport_s *rp = NULL;
		struct bfa_fcs_lport_s *port = NULL;
		struct bfa_fcs_rport_s *rp_fcs;
		int i;

		/* in min cfg lunm_list could be NULL but no commands should run. */
		@@ -2353,12 +2351,8 @@ bfa_fcpim_lunmask_delete(struct bfa_s bfa, u16 vf_id, wwn_t pwwn,
		port = bfa_fcs_lookup_port(
		&((struct bfad_s *)bfa->bfad)->bfa_fcs,
		vf_id, *pwwn);
		if (port) {
		if (port)
		*pwwn = port->port_cfg.pwwn;
		rp_fcs = bfa_fcs_lport_get_rport_by_pwwn(port, rpwwn);
		if (rp_fcs)
		rp = rp_fcs->bfa_rport;
		}
		}

		lunm_list = bfa_get_lun_mask_list(bfa);

Admin message