Commit 70b4c8cd authored Jan 10, 2006 by Eli Cohen Committed by Roland Dreier Jan 10, 2006

IPoIB: Fix error path in ipoib_mcast_dev_flush()



Don't leak memory on allocation failure for broadcast mcast group.
Also, print a warning to match handling for other mcast groups.

Signed-off-by: Eli Cohen <eli@mellanox.co.il>
Signed-off-by: Michael S. Tsirkin <mst@mellanox.co.il>
Signed-off-by: Roland Dreier <rolandd@cisco.com>

parent cf311cd4

drivers/infiniband/ulp/ipoib/ipoib_multicast.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -780,9 +780,11 @@ void ipoib_mcast_dev_flush(struct net_device *dev)
		&priv->multicast_tree);

		list_add_tail(&priv->broadcast->list, &remove_list);
		}

		priv->broadcast = nmcast;
		} else
		ipoib_warn(priv, "could not reallocate broadcast group "
		IPOIB_GID_FMT "\n",
		IPOIB_GID_ARG(priv->broadcast->mcmember.mgid));
		}

		spin_unlock_irqrestore(&priv->lock, flags);

Admin message