Commit 70802c60 authored by Antonino A. Daplas's avatar Antonino A. Daplas Committed by Linus Torvalds
Browse files

fbdev: don't show logo if driver or fbcon are modular 



It was always intended for the logo to be drawn only if both fbcon and the
driver that is mapped to it are both compiled statically.  Currently, if fbcon
is loaded prior to the driver, the logo is not shown.  Reverse the order, and
the code may attempt to draw the logo which is __initdata.  By accident, this
bug is rarely seen because this method of loading the modules is not common
and secondly, a code in fb_prepare_logo() that checks the height of the logo
(now a random value) rarely succeeds.

Fix by drawing the logo only if both fbcon and the driver are statically
compiled.

Signed-off-by: default avatarAntonino Daplas <adaplas@gmail.com>
Cc:  Jean Delvare <khali@linux-fr.org>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6314db41

drivers/video/console/fbcon.c

+15 −0
Original line number Diff line number Diff line
@@ -107,7 +107,9 @@ static struct display fb_display[MAX_NR_CONSOLES]; 


static signed char con2fb_map[MAX_NR_CONSOLES];

static signed char con2fb_map_boot[MAX_NR_CONSOLES];

#ifndef MODULE

static int logo_height;

#endif

static int logo_lines;

/* logo_shown is an index to vc_cons when >= 0; otherwise follows FBCON_LOGO

   enums.  */
@@ -576,6 +578,13 @@ static int fbcon_takeover(int show_logo) 
	return err;

}



#ifdef MODULE

static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,

			       int cols, int rows, int new_cols, int new_rows)

{

	logo_shown = FBCON_LOGO_DONTSHOW;

}

#else

static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info,

			       int cols, int rows, int new_cols, int new_rows)

{
@@ -584,6 +593,11 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, 
	int cnt, erase = vc->vc_video_erase_char, step;

	unsigned short *save = NULL, *r, *q;



	if (info->flags & FBINFO_MODULE) {

		logo_shown = FBCON_LOGO_DONTSHOW;

		return;

	}



	/*

	 * remove underline attribute from erase character

	 * if black and white framebuffer.
@@ -655,6 +669,7 @@ static void fbcon_prepare_logo(struct vc_data *vc, struct fb_info *info, 
		vc->vc_top = logo_lines;

	}

}

#endif /* MODULE */



#ifdef CONFIG_FB_TILEBLITTING

static void set_blitting_type(struct vc_data *vc, struct fb_info *info)

drivers/video/fbmem.c

+4 −2
Original line number Diff line number Diff line
@@ -418,7 +418,8 @@ int fb_prepare_logo(struct fb_info *info, int rotate) 


	memset(&fb_logo, 0, sizeof(struct logo_data));



	if (info->flags & FBINFO_MISC_TILEBLITTING)

	if (info->flags & FBINFO_MISC_TILEBLITTING ||

	    info->flags & FBINFO_MODULE)

		return 0;



	if (info->fix.visual == FB_VISUAL_DIRECTCOLOR) {
@@ -483,7 +484,8 @@ int fb_show_logo(struct fb_info *info, int rotate) 
	struct fb_image image;



	/* Return if the frame buffer is not mapped or suspended */

	if (fb_logo.logo == NULL || info->state != FBINFO_STATE_RUNNING)

	if (fb_logo.logo == NULL || info->state != FBINFO_STATE_RUNNING ||

	    info->flags & FBINFO_MODULE)

		return 0;



	image.depth = 8;

CRA Git | Maintained and supported by SUSTech CRA and CCSE