staging: rtl8723au: recv_priv.is_signal_dbg is never set (707ce72f) · Commits · 戴 / test

drivers/staging/rtl8723au/core/rtw_recv.c

+46 −58

Original line number	Diff line number	Diff line
		@@ -2314,20 +2314,10 @@ void rtw_signal_stat_timer_hdl23a(unsigned long data)
		u8 _alpha = 3; /* this value is based on converging_constant = 5000 */
		/* and sampling_interval = 1000 */

		if (adapter->recvpriv.is_signal_dbg) {
		/* update the user specific value, signal_strength_dbg, */
		/* to signal_strength, rssi */
		adapter->recvpriv.signal_strength =
		adapter->recvpriv.signal_strength_dbg;
		adapter->recvpriv.rssi =
		(s8)translate_percentage_to_dbm((u8)adapter->recvpriv.signal_strength_dbg);
		} else {
		if (recvpriv->signal_strength_data.update_req == 0) {
		/* update_req is clear, means we got rx */
		avg_signal_strength =
		recvpriv->signal_strength_data.avg_val;
		num_signal_strength =
		recvpriv->signal_strength_data.total_num;
		avg_signal_strength = recvpriv->signal_strength_data.avg_val;
		num_signal_strength = recvpriv->signal_strength_data.total_num;
		/* after avg_vals are acquired, we can re-stat */
		/* the signal values */
		recvpriv->signal_strength_data.update_req = 1;
		@@ -2353,8 +2343,7 @@ void rtw_signal_stat_timer_hdl23a(unsigned long data)
		if (tmp_s > 100)
		tmp_s = 100;

		tmp_q = (avg_signal_qual + (_alpha - 1) *
		recvpriv->signal_qual);
		tmp_q = avg_signal_qual + (_alpha - 1) * recvpriv->signal_qual;
		if (tmp_q %_alpha)
		tmp_q = tmp_q / _alpha + 1;
		else
		@@ -2371,9 +2360,8 @@ void rtw_signal_stat_timer_hdl23a(unsigned long data)
		"num_signal_qual:%u\n",
		__func__, recvpriv->signal_strength,
		recvpriv->rssi, recvpriv->signal_qual,
		num_signal_strength, num_signal_qual
		);
		}
		num_signal_strength, num_signal_qual);
		}

		rtw_set_signal_stat_timer(recvpriv);
		}

drivers/staging/rtl8723au/include/rtw_recv.h

+0 −2

Original line number	Diff line number	Diff line
		@@ -200,8 +200,6 @@ struct recv_priv {
		u8 *precv_buf;

		/* For display the phy informatiom */
		u8 is_signal_dbg; /* for debug */
		u8 signal_strength_dbg; /* for debug */
		s8 rssi;
		s8 rxpwdb;
		u8 signal_strength;

Admin message