module: merge repetitive strings in module_sig_check() (705e9195) · Commits · 戴 / test

The 'reason' variable in module_sig_check() points to 3 strings across the *switch* statement, all needlessly starting with the same text. Let's put the starting text into the pr_notice() call -- it saves 21 bytes of the object code (x86 gcc 10.2.1). Suggested-by:

Joe Perches <joe@perches.com> Reviewed-by:

Miroslav Benes <mbenes@suse.cz> Signed-off-by:

Sergey Shtylyov <s.shtylyov@omprussia.ru> Signed-off-by:

Jessica Yu <jeyu@kernel.org>

kernel/module.c

+5 −4

Original line number	Diff line number	Diff line
		@@ -2907,16 +2907,17 @@ static int module_sig_check(struct load_info *info, int flags)
		* enforcing, certain errors are non-fatal.
		*/
		case -ENODATA:
		reason = "Loading of unsigned module";
		reason = "unsigned module";
		goto decide;
		case -ENOPKG:
		reason = "Loading of module with unsupported crypto";
		reason = "module with unsupported crypto";
		goto decide;
		case -ENOKEY:
		reason = "Loading of module with unavailable key";
		reason = "module with unavailable key";
		decide:
		if (is_module_sig_enforced()) {
		pr_notice("%s: %s is rejected\n", info->name, reason);
		pr_notice("%s: loading of %s is rejected\n",
		info->name, reason);
		return -EKEYREJECTED;
		}

Admin message