Commit 705d7aa0 authored by Manoharan, Rajkumar's avatar Manoharan, Rajkumar Committed by Kalle Valo
Browse files

ath10k: fix monitor vdev for receiving other bss frames 



In order to receive other BSS entries in mesh mode, Monitor vdev
is created whenever filter flag is set with OTHER_BSS. Recently
it is root caused that setting promisc filter for Mesh interface
is causing performance and stability issues. To fix this issue,
firmware will configure appropriate rxfilters by default for mesh
vdev during vdev creation. This change fixes monitor vdev creation
based on firmware IE

Signed-off-by: default avatarRajkumar Manoharan <rmanohar@qca.qualcomm.com>
Signed-off-by: default avatarKalle Valo <kvalo@qca.qualcomm.com>
parent 5608eaf7

drivers/net/wireless/ath/ath10k/core.c

+1 −0
Original line number Diff line number Diff line
@@ -326,6 +326,7 @@ static const char *const ath10k_core_fw_feature_str[] = { 
	[ATH10K_FW_FEATURE_PEER_FLOW_CONTROL] = "peer-flow-ctrl",

	[ATH10K_FW_FEATURE_BTCOEX_PARAM] = "btcoex-param",

	[ATH10K_FW_FEATURE_SKIP_NULL_FUNC_WAR] = "skip-null-func-war",

	[ATH10K_FW_FEATURE_ALLOWS_MESH_BCAST] = "allows-mesh-bcast",

};



static unsigned int ath10k_core_get_fw_feature_str(char *buf,

drivers/net/wireless/ath/ath10k/core.h

+7 −0
Original line number Diff line number Diff line
@@ -562,6 +562,13 @@ enum ath10k_fw_features { 
	 */

	ATH10K_FW_FEATURE_SKIP_NULL_FUNC_WAR = 15,



	/* Firmware allow other BSS mesh broadcast/multicast frames without

	 * creating monitor interface. Appropriate rxfilters are programmed for

	 * mesh vdev by firmware itself. This feature flags will be used for

	 * not creating monitor vdev while configuring mesh node.

	 */

	ATH10K_FW_FEATURE_ALLOWS_MESH_BCAST = 16,



	/* keep last */

	ATH10K_FW_FEATURE_COUNT,

};

drivers/net/wireless/ath/ath10k/mac.c

+3 −1
Original line number Diff line number Diff line
@@ -1167,7 +1167,9 @@ static bool ath10k_mac_monitor_vdev_is_needed(struct ath10k *ar) 
		return false;



	return ar->monitor ||

	       ar->filter_flags & FIF_OTHER_BSS ||

	       (!test_bit(ATH10K_FW_FEATURE_ALLOWS_MESH_BCAST,

			  ar->running_fw->fw_file.fw_features) &&

		(ar->filter_flags & FIF_OTHER_BSS)) ||

	       test_bit(ATH10K_CAC_RUNNING, &ar->dev_flags);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE