Commit 705c0ee8 authored Jan 03, 2019 by John Garry Committed by Wei Xu Feb 08, 2019

bus: hisi_lpc: Don't fail probe for unrecognised child devices



Currently for ACPI-based FW we fail the probe for an unrecognised child
HID.

However, there is FW in the field with LPC child devices having fake HIDs,
namely "IPI0002", which was an IPMI device invented to support the
initial out-of-tree LPC host driver, different from the final mainline
version.

To provide compatibility support for these dodgy FWs, just discard the
unrecognised HIDs instead of failing the probe altogether.

Tested-by: Zengruan Ye <yezengruan@huawei.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Wei Xu <xuwei5@hisilicon.com>

parent bfeffd15

drivers/bus/hisi_lpc.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -522,10 +522,9 @@ static int hisi_lpc_acpi_probe(struct device *hostdev)

		if (!found) {
		dev_warn(hostdev,
		"could not find cell for child device (%s)\n",
		"could not find cell for child device (%s), discarding\n",
		hid);
		ret = -ENODEV;
		goto fail;
		continue;
		}

		pdev = platform_device_alloc(cell->name, PLATFORM_DEVID_AUTO);

Admin message