drm/todo: Add entry to remove load/unload hooks (700496fa) · Commits · 戴 / test

They're midlayer, broken, and because of the old gunk, we can't fix them. For examples see the various checks in drm_mode_object.c against dev->registered, which cannot be enforced if the driver still uses the load hook. Unfortunately our biggest driver still uses load/unload, so this would be really great to get fixed. Cc: Alex Deucher <alexander.deucher@amd.com> Cc: Harry Wentland <harry.wentland@amd.com> Reviewed-by:

Thierry Reding <treding@nvidia.com> Signed-off-by:

Daniel Vetter <daniel.vetter@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20191023144953.28190-2-daniel.vetter@ffwll.ch

Documentation/gpu/todo.rst

+17 −0

Original line number	Diff line number	Diff line
		@@ -351,6 +351,23 @@ connector register/unregister fixes

		Level: Intermediate

		Remove load/unload callbacks from all non-DRIVER_LEGACY drivers
		---------------------------------------------------------------

		The load/unload callbacks in struct &drm_driver are very much midlayers, plus
		for historical reasons they get the ordering wrong (and we can't fix that)
		between setting up the &drm_driver structure and calling drm_dev_register().

		- Rework drivers to no longer use the load/unload callbacks, directly coding the
		load/unload sequence into the driver's probe function.

		- Once all non-DRIVER_LEGACY drivers are converted, disallow the load/unload
		callbacks for all modern drivers.

		Contact: Daniel Vetter

		Level: Intermediate

		Core refactorings
		=================

Admin message