Commit 6ffe77ba authored Feb 21, 2016 by Eryu Guan Committed by Theodore Ts'o Mar 09, 2016

ext4: iterate over buffer heads correctly in move_extent_per_page()



In commit bcff2488 ("ext4: don't read blocks from disk after extents
being swapped") bh is not updated correctly in the for loop and wrong
data has been written to disk. generic/324 catches this on sub-page
block size ext4.

Fixes: bcff2488 ("ext4: don't read blocks from disk after extentsbeing swapped")
Signed-off-by: Eryu Guan <guaneryu@gmail.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>

parent 1e9d180b

fs/ext4/move_extent.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -390,6 +390,7 @@ data_copy:
		*err = ext4_get_block(orig_inode, orig_blk_offset + i, bh, 0);
		if (*err < 0)
		break;
		bh = bh->b_this_page;
		}
		if (!*err)
		*err = block_commit_write(pagep[0], from, from + replaced_size);

Admin message