Commit 6ff1cb88 authored by Arnd Bergmann's avatar Arnd Bergmann Committed by Vinod Koul
Browse files

dmaengine: sirf: use __maybe_unused to hide pm functions 



The sirf dma driver uses #ifdef to check for CONFIG_PM_SLEEP
for its suspend/resume code but then has no #ifdef for the
respective runtime PM code, so we get a warning if CONFIG_PM
is disabled altogether:

drivers/dma/sirf-dma.c:1000:12: error: 'sirfsoc_dma_runtime_resume' defined but not used [-Werror=unused-function]

This removes the existing #ifdef and instead uses __maybe_unused
annotations for all four functions to let the compiler know it
can silently drop the function definition.

Signed-off-by: default avatarArnd Bergmann <arnd@arndb.de>
Signed-off-by: default avatarVinod Koul <vinod.koul@intel.com>
parent 333f16ec

drivers/dma/sirf-dma.c

+4 −6
Original line number Diff line number Diff line
@@ -989,7 +989,7 @@ static int sirfsoc_dma_remove(struct platform_device *op) 
	return 0;

}



static int sirfsoc_dma_runtime_suspend(struct device *dev)

static int __maybe_unused sirfsoc_dma_runtime_suspend(struct device *dev)

{

	struct sirfsoc_dma *sdma = dev_get_drvdata(dev);
@@ -997,7 +997,7 @@ static int sirfsoc_dma_runtime_suspend(struct device *dev) 
	return 0;

}



static int sirfsoc_dma_runtime_resume(struct device *dev)

static int __maybe_unused sirfsoc_dma_runtime_resume(struct device *dev)

{

	struct sirfsoc_dma *sdma = dev_get_drvdata(dev);

	int ret;
@@ -1010,8 +1010,7 @@ static int sirfsoc_dma_runtime_resume(struct device *dev) 
	return 0;

}



#ifdef CONFIG_PM_SLEEP

static int sirfsoc_dma_pm_suspend(struct device *dev)

static int __maybe_unused sirfsoc_dma_pm_suspend(struct device *dev)

{

	struct sirfsoc_dma *sdma = dev_get_drvdata(dev);

	struct sirfsoc_dma_regs *save = &sdma->regs_save;
@@ -1062,7 +1061,7 @@ static int sirfsoc_dma_pm_suspend(struct device *dev) 
	return 0;

}



static int sirfsoc_dma_pm_resume(struct device *dev)

static int __maybe_unused sirfsoc_dma_pm_resume(struct device *dev)

{

	struct sirfsoc_dma *sdma = dev_get_drvdata(dev);

	struct sirfsoc_dma_regs *save = &sdma->regs_save;
@@ -1121,7 +1120,6 @@ static int sirfsoc_dma_pm_resume(struct device *dev) 


	return 0;

}

#endif



static const struct dev_pm_ops sirfsoc_dma_pm_ops = {

	SET_RUNTIME_PM_OPS(sirfsoc_dma_runtime_suspend, sirfsoc_dma_runtime_resume, NULL)

CRA Git | Maintained and supported by SUSTech CRA and CCSE