Commit 6ff06729 authored Mar 17, 2020 by Robbie Ko Committed by David Sterba Mar 25, 2020

btrfs: fix missing semaphore unlock in btrfs_sync_file



Ordered ops are started twice in sync file, once outside of inode mutex
and once inside, taking the dio semaphore. There was one error path
missing the semaphore unlock.

Fixes: aab15e8e ("Btrfs: fix rare chances for data loss when doing a fast fsync")
CC: stable@vger.kernel.org # 4.19+
Signed-off-by: Robbie Ko <robbieko@synology.com>
Reviewed-by: Filipe Manana <fdmanana@suse.com>
[ add changelog ]
Signed-off-by: David Sterba <dsterba@suse.com>

parent 351cbf6e

fs/btrfs/file.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -2117,6 +2117,7 @@ int btrfs_sync_file(struct file *file, loff_t start, loff_t end, int datasync)
		*/
		ret = start_ordered_ops(inode, start, end);
		if (ret) {
		up_write(&BTRFS_I(inode)->dio_sem);
		inode_unlock(inode);
		goto out;
		}

Admin message