Commit 6fdf482b authored Sep 08, 2010 by Mat Martineau Committed by Gustavo F. Padovan Oct 12, 2010

Bluetooth: Use a stream-oriented recvmsg with SOCK_STREAM L2CAP sockets.



L2CAP ERTM sockets can be opened with the SOCK_STREAM socket type,
which is a mandatory request for ERTM mode.

However, these sockets still have SOCK_SEQPACKET read semantics when
bt_sock_recvmsg() is used to pull data from the receive queue.  If the
application is only reading part of a frame, then the unread portion
of the frame is discarded.  If the application requests more bytes
than are in the current frame, only the current frame's data is
returned.

This patch utilizes common code derived from RFCOMM's recvmsg()
function to make L2CAP SOCK_STREAM reads behave like RFCOMM reads (and
other SOCK_STREAM sockets in general).  The application may read one
byte at a time from the input stream and not lose any data, and may
also read across L2CAP frame boundaries.

Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Signed-off-by: Gustavo F. Padovan <padovan@profusion.mobi>

parent 3d7d01df

net/bluetooth/l2cap.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -1951,6 +1951,9 @@ static int l2cap_sock_recvmsg(struct kiocb iocb, struct socket sock, struct ms

		release_sock(sk);

		if (sock->type == SOCK_STREAM)
		return bt_sock_stream_recvmsg(iocb, sock, msg, len, flags);

		return bt_sock_recvmsg(iocb, sock, msg, len, flags);
		}

Admin message