Commit 6fd369dd authored by Hans Verkuil's avatar Hans Verkuil Committed by Mauro Carvalho Chehab
Browse files

media: vimc: fill in bus_info in media_device_info 



It is good practice to fill in bus_info.

Also just use 'platform:vimc' when filling in the bus_info in querycap:
the bus_info has nothing to do with the video device name.

Signed-off-by: default avatarHans Verkuil <hverkuil-cisco@xs4all.nl>
Acked-by: default avatarHelen Koike <helen.koike@collabora.com>
Signed-off-by: default avatarMauro Carvalho Chehab <mchehab+samsung@kernel.org>
parent db89a47f

drivers/media/platform/vimc/vimc-capture.c

+1 −3
Original line number Original line Diff line number Diff line
@@ -70,12 +70,10 @@ struct vimc_cap_buffer { 
static int vimc_cap_querycap(struct file *file, void *priv,

static int vimc_cap_querycap(struct file *file, void *priv,

			     struct v4l2_capability *cap)

			     struct v4l2_capability *cap)

{

{

	struct vimc_cap_device *vcap = video_drvdata(file);



	strscpy(cap->driver, VIMC_PDEV_NAME, sizeof(cap->driver));

	strscpy(cap->driver, VIMC_PDEV_NAME, sizeof(cap->driver));

	strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card));

	strscpy(cap->card, KBUILD_MODNAME, sizeof(cap->card));

	snprintf(cap->bus_info, sizeof(cap->bus_info),

	snprintf(cap->bus_info, sizeof(cap->bus_info),

		 "platform:%s", vcap->vdev.v4l2_dev->name);

		 "platform:%s", VIMC_PDEV_NAME);





	return 0;

	return 0;

}

}

drivers/media/platform/vimc/vimc-core.c

+2 −0
Original line number Original line Diff line number Diff line
@@ -318,6 +318,8 @@ static int vimc_probe(struct platform_device *pdev) 
	/* Initialize media device */

	/* Initialize media device */

	strscpy(vimc->mdev.model, VIMC_MDEV_MODEL_NAME,

	strscpy(vimc->mdev.model, VIMC_MDEV_MODEL_NAME,

		sizeof(vimc->mdev.model));

		sizeof(vimc->mdev.model));

	snprintf(vimc->mdev.bus_info, sizeof(vimc->mdev.bus_info),

		 "platform:%s", VIMC_PDEV_NAME);

	vimc->mdev.dev = &pdev->dev;

	vimc->mdev.dev = &pdev->dev;

	media_device_init(&vimc->mdev);

	media_device_init(&vimc->mdev);

CRA Git | Maintained and supported by SUSTech CRA and CCSE