Commit 6fcaf17a authored by Jiri Slaby's avatar Jiri Slaby Committed by Jesse Barnes
Browse files

PCI hotplug: fix memory leaks 



Stanse found a cut&pasted memory leak in pciehp_queue_pushbutton_work
and shpchp_queue_pushbutton_work. info is not freed/assigned on all
paths. Fix that.

Reviewed-by: default avatarKenji Kaneshige <kaneshige.kenji@jp.fujitsu.com>
Signed-off-by: default avatarJiri Slaby <jslaby@suse.cz>
Signed-off-by: default avatarJesse Barnes <jbarnes@virtuousgeek.org>
parent 3b7a17fc

drivers/pci/hotplug/pciehp_ctrl.c

+1 −0
Original line number Diff line number Diff line
@@ -341,6 +341,7 @@ void pciehp_queue_pushbutton_work(struct work_struct *work) 
		p_slot->state = POWERON_STATE;

		break;

	default:

		kfree(info);

		goto out;

	}

	queue_work(pciehp_wq, &info->work);

drivers/pci/hotplug/shpchp_ctrl.c

+1 −0
Original line number Diff line number Diff line
@@ -453,6 +453,7 @@ void shpchp_queue_pushbutton_work(struct work_struct *work) 
		p_slot->state = POWERON_STATE;

		break;

	default:

		kfree(info);

		goto out;

	}

	queue_work(shpchp_wq, &info->work);

CRA Git | Maintained and supported by SUSTech CRA and CCSE