Commit 6fa0321a authored May 17, 2019 by Keith Busch

nvme: Fix known effects

We're trying to append known effects to the ones reported in the
controller's log. The original patch accomplished this, but something
went wrong when patch was merged causing the effects log to override
the known effects.

Link: http://lists.infradead.org/pipermail/linux-nvme/2019-May/023710.html


Fixes: f4524cc4 ("nvme-pci: add known admin effects to augument admin effects log page")
Cc: Maxim Levitsky <mlevitsk@redhat.com>
Signed-off-by: Keith Busch <keith.busch@intel.com>

parent d6135c3a

drivers/nvme/host/core.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1257,9 +1257,9 @@ static u32 nvme_passthru_start(struct nvme_ctrl ctrl, struct nvme_ns ns,
		return 0;
		}

		effects \|= nvme_known_admin_effects(opcode);
		if (ctrl->effects)
		effects = le32_to_cpu(ctrl->effects->acs[opcode]);
		effects \|= nvme_known_admin_effects(opcode);

		/*
		* For simplicity, IO to all namespaces is quiesced even if the command

Admin message