Commit 6f9c9607 authored by Javier González's avatar Javier González Committed by Jens Axboe
Browse files

lightnvm: pblk: check for chunk size before allocating it



Do the check for the chunk state after making sure that the chunk type
is supported.

Fixes: 32ef9412 ("lightnvm: pblk: implement get log report chunk")
Signed-off-by: default avatarJavier González <javier@cnexlabs.com>
Signed-off-by: default avatarMatias Bjørling <mb@lightnvm.io>
Signed-off-by: default avatarJens Axboe <axboe@kernel.dk>
parent 8e55c07b
Loading
Loading
Loading
Loading
+3 −3
Original line number Diff line number Diff line
@@ -751,14 +751,14 @@ static int pblk_setup_line_meta_20(struct pblk *pblk, struct pblk_line *line,
		chunk->cnlb = chunk_meta->cnlb;
		chunk->wp = chunk_meta->wp;

		if (!(chunk->state & NVM_CHK_ST_OFFLINE))
			continue;

		if (chunk->type & NVM_CHK_TP_SZ_SPEC) {
			WARN_ONCE(1, "pblk: custom-sized chunks unsupported\n");
			continue;
		}

		if (!(chunk->state & NVM_CHK_ST_OFFLINE))
			continue;

		set_bit(pos, line->blk_bitmap);
		nr_bad_chks++;
	}