Commit 6f8e4ad0 authored by Dan Carpenter's avatar Dan Carpenter Committed by David S. Miller
Browse files

sock_diag: off by one checks 



These tests are off by one because sock_diag_handlers[] only has AF_MAX
elements.

Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Acked-by: default avatarPavel Emelyanov <xemul@parallels.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 865d9f9f

net/core/sock_diag.c

+2 −2
Original line number Diff line number Diff line
@@ -32,7 +32,7 @@ int sock_diag_register(struct sock_diag_handler *hndl) 
{

	int err = 0;



	if (hndl->family > AF_MAX)

	if (hndl->family >= AF_MAX)

		return -EINVAL;



	mutex_lock(&sock_diag_table_mutex);
@@ -50,7 +50,7 @@ void sock_diag_unregister(struct sock_diag_handler *hnld) 
{

	int family = hnld->family;



	if (family > AF_MAX)

	if (family >= AF_MAX)

		return;



	mutex_lock(&sock_diag_table_mutex);

CRA Git | Maintained and supported by SUSTech CRA and CCSE