Commit 6f8cd246 authored May 22, 2020 by Dinghao Liu Committed by Linus Walleij May 25, 2020

gpio: rcar: Fix runtime PM imbalance on error

pm_runtime_get_sync() increments the runtime PM usage counter even
when it returns an error code. Thus a pairing decrement is needed on
the error handling path to keep the counter balanced.

Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Link: https://lore.kernel.org/r/20200522080839.32612-1-dinghao.liu@zju.edu.cn

Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c22fc62b

drivers/gpio/gpio-rcar.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -250,8 +250,10 @@ static int gpio_rcar_request(struct gpio_chip *chip, unsigned offset)
		int error;

		error = pm_runtime_get_sync(p->dev);
		if (error < 0)
		if (error < 0) {
		pm_runtime_put(p->dev);
		return error;
		}

		error = pinctrl_gpio_request(chip->base + offset);
		if (error)