Commit 6f7219fe authored by Guennadi Liakhovetski's avatar Guennadi Liakhovetski Committed by Vinod Koul
Browse files

soundwire: intel: (cosmetic) remove multiple superfluous "else" statements 



No need for an "else" after a "return" statement. Remove multiple such
occurrences in Intel-specific code.

Signed-off-by: default avatarGuennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Link: https://lore.kernel.org/r/20200508003046.23162-3-guennadi.liakhovetski@linux.intel.com


Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f779ad09

drivers/soundwire/cadence_master.c

+6 −2
Original line number Diff line number Diff line
@@ -407,7 +407,9 @@ cdns_fill_msg_resp(struct sdw_cdns *cdns, 
	if (nack) {

		dev_err_ratelimited(cdns->dev, "Msg NACKed for Slave %d\n", msg->dev_num);

		return SDW_CMD_FAIL;

	} else if (no_ack) {

	}



	if (no_ack) {

		dev_dbg_ratelimited(cdns->dev, "Msg ignored for Slave %d\n", msg->dev_num);

		return SDW_CMD_IGNORED;

	}
@@ -520,7 +522,9 @@ cdns_program_scp_addr(struct sdw_cdns *cdns, struct sdw_msg *msg) 
		dev_err_ratelimited(cdns->dev,

				    "SCP_addrpage NACKed for Slave %d\n", msg->dev_num);

		return SDW_CMD_FAIL;

	} else if (no_ack) {

	}



	if (no_ack) {

		dev_dbg_ratelimited(cdns->dev,

				    "SCP_addrpage ignored for Slave %d\n", msg->dev_num);

		return SDW_CMD_IGNORED;

drivers/soundwire/intel_init.c

+3 −1
Original line number Diff line number Diff line
@@ -86,7 +86,9 @@ static struct sdw_intel_ctx 
		dev_err(&adev->dev, "Link count %d exceeds max %d\n",

			count, SDW_MAX_LINKS);

		return NULL;

	} else if (!count) {

	}



	if (!count) {

		dev_warn(&adev->dev, "No SoundWire links detected\n");

		return NULL;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE