Commit 6f68794c authored Feb 10, 2012 by Robert Love Committed by James Bottomley Feb 19, 2012

[SCSI] fcoe: Rename out_nomod label to out_putmod



The label implies that it should be called when
there is 'nomod.' I read that to mean that the
module reference 'get' failed. However, it's only
called when the module reference 'get' succeeded.

I think it makes more sense to name the label,
'out_putmod' since it should be called when we
need to 'put' the module reference taken in the
routine before returning.

Signed-off-by: Robert Love <robert.w.love@intel.com>
Tested-by: Ross Brattain <ross.b.brattain@intel.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 7e5adcfb

drivers/scsi/fcoe/fcoe.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -380,7 +380,7 @@ static struct fcoe_interface fcoe_interface_create(struct net_device netdev,
		if (!fcoe) {
		FCOE_NETDEV_DBG(netdev, "Could not allocate fcoe structure\n");
		fcoe = ERR_PTR(-ENOMEM);
		goto out_nomod;
		goto out_putmod;
		}

		dev_hold(netdev);
		@@ -400,12 +400,12 @@ static struct fcoe_interface fcoe_interface_create(struct net_device netdev,
		kfree(fcoe);
		dev_put(netdev);
		fcoe = ERR_PTR(err);
		goto out_nomod;
		goto out_putmod;
		}

		goto out;

		out_nomod:
		out_putmod:
		module_put(THIS_MODULE);
		out:
		return fcoe;

Admin message