Commit 6f627683 authored Oct 10, 2006 by Michael Buesch Committed by Jeff Garzik Oct 11, 2006

[PATCH] b44: fix eeprom endianess issue



This fixes eeprom read on big-endian architectures.

readw returns the data in CPU order.  With cpu_to_le16 we convert it to little
endian, because "ptr" is a pointer to a _byte_ arrray.  See the cast above.  A
byte array is little endian.

The bug is:

Reading u16 values with readw, casting them into an u8 array and accessing
this u8 array as an u8 (byte) array.  The correct fix is to swap the
CPU-ordering value returned by readw into little endian, as the u8 array is
little endian.

This compiles to nothing on little endian hardware (so it does not change b44
code on LE hardware), but _fixes_ code on BE hardware.

Signed-off-by: Michael Buesch <mb@bu3sch.de>
Cc: Jeff Garzik <jeff@garzik.org>
Signed-off-by: Andrew Morton <akpm@osdl.org>
Signed-off-by: Jeff Garzik <jeff@garzik.org>

parent 12f417ee

drivers/net/b44.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2056,7 +2056,7 @@ static int b44_read_eeprom(struct b44 bp, u8 data)
		u16 ptr = (u16 ) data;

		for (i = 0; i < 128; i += 2)
		ptr[i / 2] = readw(bp->regs + 4096 + i);
		ptr[i / 2] = cpu_to_le16(readw(bp->regs + 4096 + i));

		return 0;
		}

Admin message