Commit 6f5a55f1 authored Feb 05, 2010 by Linus Torvalds

Fix potential crash with sys_move_pages



We incorrectly depended on the 'node_state/node_isset()' functions
testing the node range, rather than checking it explicitly.  That's not
reliable, even if it might often happen to work.  So do the proper
explicit test.

Reported-by: Marcus Meissner <meissner@suse.de>
Acked-and-tested-by: Brice Goglin <Brice.Goglin@inria.fr>
Acked-by: Hugh Dickins <hugh.dickins@tiscali.co.uk>
Cc: stable@kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9d9c3a51

mm/migrate.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -912,6 +912,9 @@ static int do_pages_move(struct mm_struct mm, struct task_struct task,
		goto out_pm;

		err = -ENODEV;
		if (node < 0 \|\| node >= MAX_NUMNODES)
		goto out_pm;

		if (!node_state(node, N_HIGH_MEMORY))
		goto out_pm;

Admin message