leds: da903x: fix use-after-free on unbind (6f4aa357) · Commits · 戴 / test

Several MFD child drivers register their class devices directly under the parent device. This means you cannot blindly do devres conversions so that deregistration ends up being tied to the parent device, something which leads to use-after-free on driver unbind when the class device is released while still being registered. Fixes: ("leds: da903x: Use devm_led_classdev_register") Cc: stable <stable@vger.kernel.org> # 4.6 Cc: Amitoj Kaur Chawla <amitoj1606@gmail.com> Signed-off-by:

Johan Hovold <johan@kernel.org> Signed-off-by:

Pavel Machek <pavel@ucw.cz>

drivers/leds/leds-da903x.c

+13 −1

Original line number	Diff line number	Diff line
		@@ -110,12 +110,23 @@ static int da903x_led_probe(struct platform_device *pdev)
		led->flags = pdata->flags;
		led->master = pdev->dev.parent;

		ret = devm_led_classdev_register(led->master, &led->cdev);
		ret = led_classdev_register(led->master, &led->cdev);
		if (ret) {
		dev_err(&pdev->dev, "failed to register LED %d\n", id);
		return ret;
		}

		platform_set_drvdata(pdev, led);

		return 0;
		}

		static int da903x_led_remove(struct platform_device *pdev)
		{
		struct da903x_led *led = platform_get_drvdata(pdev);

		led_classdev_unregister(&led->cdev);

		return 0;
		}

		@@ -124,6 +135,7 @@ static struct platform_driver da903x_led_driver = {
		.name = "da903x-led",
		},
		.probe = da903x_led_probe,
		.remove = da903x_led_remove,
		};

		module_platform_driver(da903x_led_driver);

Admin message